logging - Log statements prevent refactoring: how to help this? -

-

I have some relatively large legacy method that I want to reflector. This "bulleted method" type fits into "effectively working with the heritage code" referred to as Michael Wings, and thus it can be divided into direct sequences in many sequential ways. But each of its sequential steps produces some log messages, and to create that message, more data is required than that step, so when I try to remove the method, I say, the 6-parameter method If I had removed those log status then I would have only one method with 1 parameter. So I can not effectively refact anything. And I just do not have permission to leave log statements.

A part of the method looks like this: 

  // Device device = getDevice (deviceID) before much device; Boolean is First Registration = Wrong; If (device == faucet) {/.logger.trace ("DeviceId", deviceID, "ADM", adminCode, "phone", clientData.getPhone ()); Logger.info ("Device's first registration device ID -" + deviceID); * / IsFirstRegistration = true; } Else {/.comlogger.trace ("DeviceId", deviceID, "ADM", adminCode, "Phone", clientData.getPhone ()); Logger.info ("Device ID -" + deviceID + "is first registered by adminCode:" + device.getAdminCode ()); As a lot of code, you see, commenting on logging statements. In this case I can extract the method  boolean isFirstRegistration (string device id) . But when they are unconnected,  signatures for Boolean Blocks First Registration (String Device ID, String AdminCode, Client Data Client Data) . And this is not the most extreme case, the first glimpse is just one. Do you have any idea how should I refactor this kind of method?

Turn on logging in the Sprout class helper class and feed it to all the data, because it is required.

Update: By using the presented instance variable, for example, myLogger.setDevice I will; Similarly logar log methods such as trace divis admin code and androphone () and logfest registration () for adminCode, clientData, etc., where it uses its image variables Wherever the variables change, feed them again on the loozer. Now, logger passes in ways that you can find out, as well as new parameters (but no longer) require any parameters directly, and what is required from your logar removed method.

In addition, if it is starting to look like your logger then your method is very intimate, alternatively the method must be removed in a new category and some local variables change in the example variable Must do; So the logger could instead ask the new class for the values ​​rather than catching them, but as an assistant assistant, the logger class is probably a small, less effective, refactoring. Whether it is good or bad it depends on where you want to go with it.


Comments

Post a Comment

Popular posts from this blog

c# - sqlDecimal to decimal clr stored procedure Unable to cast object of type 'System.Data.SqlTypes.SqlDecimal' to type 'System.IConvertible' -

-
I'm new to this I'm writing a clr. stored procedure that can be used to get values ​​used in a calculation Call for another stored procedure for Gives an archived methodology int (I think SqlInt32? Value of the table's value is int) which is then necessary to convert to decimal. Here I have the code: Public static integral mood (SQL MDMMYLUE, escalistering AMY type, out of SQLDCM Result) {aResult = 0; Try {SqlConnection conn = New SqlConnection ("Reference Connection = True"); SqlCommand cmd = New SqlCommand ("sp_GetType", conn); Cmd.Parameters.AddWithValue ("@ myValueType", aMyValueType); Cmd.CommandType = CommandType.StoredProcedure; Conn.Open (); Object type = CMD. Exclamation Asser (); Conn.Close (); Decimal type FORCalculation = Convert. ToDecimal (type); Decimal value = convert toDecimal (aMyValue); // ** calculation calc = new calculation (); Decimal result = calorie.docalulation (typefarculation, value); I get an exception...
Read more

Calling GetGUIThreadInfo from Outlook VBA -

-
I need to find the active window'm writing a VBA macro in MS Outlook, which is a specific process. The goal of this is to get the active window / document name even if its original application has more than one document interface. User processor with GetCurrentThreadId is active, I am using GetGUIThreadInfo to get .dll. Here is the correct code: private type RECT as as Left LongPtr top LongPtr right LongPtr down LongPtr termination of private type GUITHREADINFO cbSize as LongPtr flags LongPtr hwndActive LongPtr hwndFocus LongPtr hwndCapture LongPtr as as as as as reset as LongPtr rcCaret as LongPtr hwndCreate as LongPtr hwndMoveSize as HwndMenuOwner end of Private Equity PtrSafe function GetWindowThreadProcessId Lib "user32" (_BVV hnw LongPtr as LongPtr Nig Mr. announced as PtrSafe function GetGUIThreadInfo Lib "user32" _ (ByVal dwthreadid as LongPtr, _ lpguithreadinfo as GUITHREADINFO) LongPtr Sub MyFunction () as dim strWindowTitle string = space as s...
Read more

Obfuscating Python code? -

-
I'm looking for a way to hide my Python source code. print "Hello World!" How can I encode this example so that it is not human-readable? I have been asked to use Base 64 but I'm not sure how. itemprop = "text"> It is limited only, first level ambiguous resolution, but has built-in: byte-code in Python Is a compiler for: dragon-o-m py_compile & lt; Your program.py & gt; creates a .pyo file with a byte-code, and where the docstrings are removed, etc. You can rename .pyo with the .py extension, and python & lt; Your program.py & gt; runs as your program, but it does not have your source code. PS : If your program blur modules like this, you need to rename them with the .pyc suffix (I Not sure it will not break a day), or you can work with .pyo and run them with python -o ... .pyo ( Import should work). This will allow dragon to search your modules (otherwise, Python looks for the .py module).
Read more