c# - Throwing exceptions in switch statements when no specified case can be handled -

-

I've been writing C # for the past 8 years and have become a very protective OOP programmer. Working in a statically typed language, you validate the arguments in such methods and leave the exception, where you will not be in dynamic and more liberal languages. I consider myself a specialist in C # and others are looking for feedback from best C # developers on best practices.

Let's say we have an MVC app which is a function.: 

  public JsonResult ChangePassword (string username, string currentPassword, string newPassword) {switch (this. membershipService.ValidateLogin (username, currentPassword)) {case UserValidationResult.BasUsername: case UserValidationResult.BadPassword: // abort: invalid JsonResult return // wrong password username / pass case combo UserValidationResult.TrialExpired // abortion: local Returns JsonResult // with error message that is user Can not log in because he UserValidationResult.Success: Break case ended its trial period; } // Now password is now that the user is validated}}

membershipService.ValidateLogin () returns a UserValidationResult as the form of enum have been defined: 

  enum UserValidationResult {BadUsername, BadPassword, TrialExpired, success}

a defensive programmer, I ChangePassword () up Being changed will be method, then return an unrecognized exception to UserValidationResult ValidateLogin () return value: 

  public JsonResult ChangePassword (string aligned User name, string currentPassword, string newPassword) {switch (this.membershipService.ValidateLogin (username, currentPassword)) {case UserValidationResult.BasUsername: case UserValidationResult.BadPassword: // abort: JsonResult return // invalid user with local error message Name / Pass Combo Case UserValidationResult.TrialExpired / abort: with JsonResult local error message // This user can not log in because their trial period has expired UserValidationResult.Success: break; Default: New NotImplementedException Throw ("Unrecognized UserValidationResult Value."); // or NotSupportedException () break; } // Now change password that the user is valid

I always considered a pattern like the previous snippet on an ideal exercise. For example, what would happen if a developer is required, now when users try to login, for this business reason, do they first consider contacting the business? So UserValidationResult has been updated to the definition: 

  enum UserValidationResult {BadUsername, BadPassword, test, compile, ContactUs, success}

developer new enum values ​​( UserValidationResult.ContactUs ) back is to ValidateLogin () to change the body of law, but Forgot to update ChangePassword () . Without exception in the switch, the user is allowed to change his password even when his login attempt should not be valid even at the first place!

Is it just me, or is it the default of : throw a new exception () is a good idea? I saw it a few years ago and always (after provoking it) it is considered a best practice.

I always throw exceptions in this case. Consider using, which gives rich information in this situation.


Comments

Post a Comment

Popular posts from this blog

c# - sqlDecimal to decimal clr stored procedure Unable to cast object of type 'System.Data.SqlTypes.SqlDecimal' to type 'System.IConvertible' -

-
I'm new to this I'm writing a clr. stored procedure that can be used to get values ​​used in a calculation Call for another stored procedure for Gives an archived methodology int (I think SqlInt32? Value of the table's value is int) which is then necessary to convert to decimal. Here I have the code: Public static integral mood (SQL MDMMYLUE, escalistering AMY type, out of SQLDCM Result) {aResult = 0; Try {SqlConnection conn = New SqlConnection ("Reference Connection = True"); SqlCommand cmd = New SqlCommand ("sp_GetType", conn); Cmd.Parameters.AddWithValue ("@ myValueType", aMyValueType); Cmd.CommandType = CommandType.StoredProcedure; Conn.Open (); Object type = CMD. Exclamation Asser (); Conn.Close (); Decimal type FORCalculation = Convert. ToDecimal (type); Decimal value = convert toDecimal (aMyValue); // ** calculation calc = new calculation (); Decimal result = calorie.docalulation (typefarculation, value); I get an exception...
Read more

Calling GetGUIThreadInfo from Outlook VBA -

-
I need to find the active window'm writing a VBA macro in MS Outlook, which is a specific process. The goal of this is to get the active window / document name even if its original application has more than one document interface. User processor with GetCurrentThreadId is active, I am using GetGUIThreadInfo to get .dll. Here is the correct code: private type RECT as as Left LongPtr top LongPtr right LongPtr down LongPtr termination of private type GUITHREADINFO cbSize as LongPtr flags LongPtr hwndActive LongPtr hwndFocus LongPtr hwndCapture LongPtr as as as as as reset as LongPtr rcCaret as LongPtr hwndCreate as LongPtr hwndMoveSize as HwndMenuOwner end of Private Equity PtrSafe function GetWindowThreadProcessId Lib "user32" (_BVV hnw LongPtr as LongPtr Nig Mr. announced as PtrSafe function GetGUIThreadInfo Lib "user32" _ (ByVal dwthreadid as LongPtr, _ lpguithreadinfo as GUITHREADINFO) LongPtr Sub MyFunction () as dim strWindowTitle string = space as s...
Read more

Obfuscating Python code? -

-
I'm looking for a way to hide my Python source code. print "Hello World!" How can I encode this example so that it is not human-readable? I have been asked to use Base 64 but I'm not sure how. itemprop = "text"> It is limited only, first level ambiguous resolution, but has built-in: byte-code in Python Is a compiler for: dragon-o-m py_compile & lt; Your program.py & gt; creates a .pyo file with a byte-code, and where the docstrings are removed, etc. You can rename .pyo with the .py extension, and python & lt; Your program.py & gt; runs as your program, but it does not have your source code. PS : If your program blur modules like this, you need to rename them with the .pyc suffix (I Not sure it will not break a day), or you can work with .pyo and run them with python -o ... .pyo ( Import should work). This will allow dragon to search your modules (otherwise, Python looks for the .py module).
Read more